Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In step 3 warnings, number of CPUs should be estimated from Computer setup #937

Open
mikibonacci opened this issue Nov 21, 2024 · 3 comments · May be fixed by #971
Open

In step 3 warnings, number of CPUs should be estimated from Computer setup #937

mikibonacci opened this issue Nov 21, 2024 · 3 comments · May be fixed by #971
Assignees
Labels
enhancement New feature or request

Comments

@mikibonacci
Copy link
Member

We should rely on the default number of CPUs, as the python os.get_cpus (or similar) will not correctly work on deployments where host and single instance have different number of dedicated cores (which is almost always the case, the single instance will always have only a fraction of the host resources)

@mikibonacci mikibonacci added the enhancement New feature or request label Nov 21, 2024
@mikibonacci mikibonacci self-assigned this Nov 21, 2024
@edan-bainglass
Copy link
Member

Hi @mikibonacci. Is this yet to be implemented? It is something additional to your recently implemented warning system?

@mikibonacci
Copy link
Member Author

mikibonacci commented Dec 10, 2024

Hi @edan-bainglass, yes, it needs to be implemented. Is a fixing to the warning system. The issue is that now we estimate the available cores using python, but this detects the total cores of the host system, not the ones assigned to the container (this is an issue mainly in kubernetes clusters, e.g. demo server). We need to get the number of available cpus from the code setup parameters, defined when the qe default codes are installed (if I remember correctly, @unkcpz told me that this is done when the container is generated, right?).

I still need to check this, should happen this week

@unkcpz
Copy link
Member

unkcpz commented Dec 10, 2024

if I remember correctly, @unkcpz told me that this is done when the container is generated, right?).

Yes, it is set after container start bind to the computer node setup. By verdi computer show <localhost-hq> you can see the number of CPUs can be used (and by API as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants