Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputPort.default raises a RuntimeError if no default was defined #280

Open
sphuber opened this issue Dec 8, 2023 · 0 comments
Open

InputPort.default raises a RuntimeError if no default was defined #280

sphuber opened this issue Dec 8, 2023 · 0 comments
Labels
priority/nice to have topic/ports type/enhancement

Comments

@sphuber
Copy link
Collaborator

sphuber commented Dec 8, 2023

plumpy/src/plumpy/ports.py

Line 271 in ff5770f

raise RuntimeError('No default')

This is positively weird design. Not sure what the original reasoning was but of all the ways of communicating to the caller that no default was set, this has got to be one of the least expected ones. We should probably just have it defined the UNSPECIFIED tuple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/nice to have topic/ports type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sphuber