Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph generated at the very end #108

Open
BatoolMM opened this issue Jul 22, 2024 · 3 comments
Open

Graph generated at the very end #108

BatoolMM opened this issue Jul 22, 2024 · 3 comments
Assignees
Labels
enhancement Feature improvement or addition question Further information is requested

Comments

@BatoolMM
Copy link
Member

BatoolMM commented Jul 22, 2024

Currently, there is a graph that is generated at the very end that shows the mapping, my questions:

  • Is there any value of enabling the user to customise it, it is created with ggplot - but not sure if there is a function of making it easily customisable by the user or adding it to doc.
  • is it worth to add anything about it in the docs, I am not sure if I saw it in the README file.

(Not important at this stage but wanted to ask it)

@RayStick
Copy link
Member

Thanks Batool!

Currently this is what is in the README:

The PLOT png file saves a simple plot displaying the count of domain codes for that table.

To add more context to why this plot exists, we could expand and say:

The PLOT png file saves a simple plot displaying the count of domain codes for that table. This is the same information captured in the OUTPUT csv - the plot allows a quick way for a user to visualise which domains are represented for this table.

With regard to customizing, I am open to it, but don't want to make it too complicated as it's such a simple plot. Also, if we allow a user to customize, we will need to make sure the plot is still formatted well. At the moment, the simplicity means it should always work. Did you have thoughts on how a user might want to customize? They also have the option of loading the OUTPUT csv in their own code later

@RayStick RayStick added the question Further information is requested label Jul 23, 2024
@BatoolMM
Copy link
Member Author

Ahh I see - I see. I was reflecting on other functions I've seen before. Since this is a ggplot created from a CSV file, I know it's a very simple one, but I believe there's a way to make it editable as a ggplot. This would allow users to add other layers from ggplot without requiring extra work from you. Visualization is always appealing for users, even if it's very simple. I'll need to think more about this.

@RayStick
Copy link
Member

RayStick commented Jul 23, 2024

Ah yes, I see what you mean now! Let's return to this later. I think we may need to use R shiny

@RayStick RayStick added the enhancement Feature improvement or addition label Jul 23, 2024
@RayStick RayStick added this to the Improve plots! milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature improvement or addition question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants