Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests for plotting functions #141

Open
RayStick opened this issue Nov 26, 2024 · 0 comments
Open

Improve unit tests for plotting functions #141

RayStick opened this issue Nov 26, 2024 · 0 comments
Assignees
@RayStick
Labels
enhancement Feature improvement or addition help wanted Extra attention is needed
Milestone
Improve plots!

Comments

@RayStick
Copy link
Member

Currently the unit tests for test-end_plot.R and test-ref_plot.R are pretty basic.

Should consider using snapshot tests!

Specifically, the rOpenSci guidance said:

For testing your functions creating plots, we suggest using vdiffr, an extension of the testthat package that relies on testthat snapshot tests.
@RayStick RayStick self-assigned this Nov 26, 2024
@RayStick RayStick added enhancement Feature improvement or addition help wanted Extra attention is needed labels Nov 26, 2024
@RayStick RayStick mentioned this issue Nov 26, 2024
Closed
26 tasks
@RayStick RayStick added this to the Improve plots! milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RayStick RayStick

Labels
enhancement Feature improvement or addition help wanted Extra attention is needed
Projects
None yet
Milestone
Improve plots!
Development

No branches or pull requests
1 participant
@RayStick