Add minimal typing for decorators #895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The task of adding full typing to the library is quite a long one. We can wait long enough for contributors to have time.
Since we are already using the library today, I suggest covering the smallest, but most frequently used part of it in the simplest way.
Even if it is more correct to describe ParamSpec, etc. - let's do it in this minimal version. And as soon as the contributors have the strength and time, we will redo it in the target form.
Are there changes in behavior for the user?
Displaying original type hints of decorated function
Before
After
Related issue number
Related to #512 (as a temporary solution)
Checklist