You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
(Context: we want to just restart workers if they consume too much memory, but specifically at the end of a request so we don't drop drop any requests)
It's either this or adding a workerShouldExit method as a config? What do you think? Can I safely use the onServer method, or is this subject to removal?
(Also on the subject of undocumented arguments - what about documenting context too? It's useful for collecting stats.)
onServer is public API and here to stay. It's how we can have access to app as well as the master process so that we can extend hypernova's server functionality.
I'm using
onServer
to be able to hook into express before the batch route is added, so I can do something like this: https://stackoverflow.com/a/21858212/4396258(Context: we want to just restart workers if they consume too much memory, but specifically at the end of a request so we don't drop drop any requests)
It's either this or adding a
workerShouldExit
method as a config? What do you think? Can I safely use theonServer
method, or is this subject to removal?(Also on the subject of undocumented arguments - what about documenting
context
too? It's useful for collecting stats.)@ljharb @goatslacker
The text was updated successfully, but these errors were encountered: