Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upload v0.1.2 to Maven Central #14

Closed
cohei opened this issue Mar 18, 2023 · 6 comments
Closed

Please upload v0.1.2 to Maven Central #14

cohei opened this issue Mar 18, 2023 · 6 comments

Comments

@cohei
Copy link

cohei commented Mar 18, 2023

https://mvnrepository.com/artifact/io.airbrake/logback

Hi,

I think v0.1.2 is not available because it's not on Maven Central.

fixes: #9 #12 (comment)

@thibaut-wed
Copy link

Hello @airbrake,

Do you have any plan to release this library version on Maven Central as asked in the previous comment?
Currently airbrake-logback is unusable on Java 17.

Thanks

@luisgsotoaboal
Copy link

luisgsotoaboal commented Sep 19, 2023

Hi 👋

I was doing some tests yesterday and it turns out airbrake-logback v0.1.1 is not compatible, not just with JDK 17, but also with any of the airbrake-javabrake 0.2.x nor 0.3.0 versions released in the last five years, because airbrake-logback v0.1.1 is using a Notifier(int, String) constructor that was removed from airbrake-javabrake in March 2021 in favor of the current Notifier(Config) constructor:

Caused by: java.lang.NoSuchMethodError: 'void io.airbrake.javabrake.Notifier.<init>(int, java.lang.String)'
        at      at io.airbrake.logback.AirbrakeAppender.initNotifier(AirbrakeAppender.java:43)
        at      at io.airbrake.logback.AirbrakeAppender.setProjectKey(AirbrakeAppender.java:32)

This forces me to use airbrake-javabrake v0.1.6 which as I said is more than 5 years old, and I don't even know if it's still fully compatible with Airbrake's current API.

All of this is of course solved in airbrake-logback v0.1.2 (that's why I'm writing a comment here instead of opening a new issue). Even the README tells us to use v0.1.2 but, as @thibaut-wed and @cohei mentioned, v0.1.2 is not available on Maven so we cannot use it.

We are getting some pressure to just switch to airbrake-log4javabrake2 which AFAIK doesn't suffer from any of this problems, but we'd really like to stay with Logback as that's what we use in most of our services.

We would really appreciate it if you could just release v0.1.2 to Maven Central. Thanks in advance.


PS: tagging @sumitjoshi1989 as v0.1.2 committer, @mmcdaris as v0.1.2 reviewer and approver, and @thompiler as the one who deleted the already-merged logback_v0.1.2 branch barely 11 hours ago. Sorry for bothering you, guys, I just hope one of you is able to solve this. Thanks!

@luisgsotoaboal
Copy link

@cohei It also fixes #9, you may want to include that one too in your original message.

@cohei
Copy link
Author

cohei commented Sep 20, 2023

OK, I'll add it.

@mmcdaris
Copy link
Member

mmcdaris commented Oct 3, 2023

Apologies for the delay on this one. The release slipped through the cracks. We now see v0.1.2 live on mvn repository.
Please let us know if you have any further issues. Closing this one out.

@mmcdaris mmcdaris closed this as completed Oct 3, 2023
@luisgsotoaboal
Copy link

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants