891: Fix LastLook expired transactions #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
changed the title
dmosites
approved these changes
Apr 17, 2024
added 7 commits
April 17, 2024 22:39
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #891
Expiry of LastLook transactions are now handled in the transactionHooks file.
Removed all logic for keeping track of expired transactions from store. This is considered bad practice, you should only store data in your store. Adding timeouts will create side effects and will make cleanup more complicated.
Added a SubmittedOrderUnderConsideration interface for LastLook orders that are submitted but not have a transaction hash yet and are sent for consideration to LastLook.
Removed the
last-lookandrequest-for-quotetypes. All orders are now the same, except when it has aisLastLook=true. Then the hash can be optional.