fallback locale for csv asset loader #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bw-flagship
requested changes
Dec 17, 2023
| @@ -12,6 +12,9 @@ import 'asset_loader.dart'; | |||
| // | |||
| class CsvAssetLoader extends AssetLoader { | |||
| CSVParser? csvParser; | |||
| final Locale? fallbackLocale; | |||
|
|
|||
| CsvAssetLoader([this.fallbackLocale]); | |||
There was a problem hiding this comment.
I would prefer optional args over this:
CsvAssetLoader({this.fallbackLocale});
| final indexLocale = lines.first.indexOf(localeName); | ||
| final indexFallbackLocale = |
There was a problem hiding this comment.
nullable instead of -1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if fallback locale provided to csv asset loader empty values will be replaced by provided locale values