fix: if inside string ignore text-delimiters #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CSV to latest version which fixes issue #close2/csv#70. and made one default value 'useAutodetect' to false to make it work.
Description:
I had a line containing a comma (,) inside "" in the langs.csv locale file
Example:
contact_info,"Send mail, suggestion or feedback",إرسال بريد، اقتراح أو ملاحظات,"Məktub, təklif və ya rəy göndərin","ইমেল, পরামর্শ বা প্রতিক্রিয়া পাঠান","Mail, Vorschlag oder Feedback senden","Envoyer un courriel, une suggestion ou un retour d'utilisation","Kirim surat, saran atau masukan","Invia mail, suggerimenti o feedback","Hantar surat, cadangan atau maklum balas","Отправить письмо, предложение или отзыв","Posta, öneri veya geri bildirim gönderin",ایمیل، تجاویز، مشورہ بھیجیں
Here in my app, it was rendering only ["Send mail] and missing the next part of [, suggestion or feedback] as both are separated by comma. After some research I found this issue is already fixed by CSV library in latest version. So I updated CSV to latest here and made 1 change according to it.