Add ability to embed SVG snippits into tags #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change gives finer grained control over the produced XML by allowing tags that were produced by start / end functions to have their contents defined by a function that receives a temporary SVG object context.
This work can close #74 by allowing code like this:
This is backwards compatible, but as seen above, it can change how the library is used and the flow of the code when the library is used.
I implemented this pattern across all methods that exhibit the start / end pattern. It may or may not be necessary to do all of them, and in some cases it might produce invalid SVGs, but that was already possible with the library -- users should continue to be aware of what is valid.