New example of IP blocking #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New example of IP blocking
New example of IP blocking
evan-hughes
requested changes
Oct 15, 2024
| import { blockedIPs } from './ipList.js'; | ||
|
|
||
| export async function onClientRequest(request) { | ||
| const clientIP = request.getVariable('PMUSER_IP'); |
There was a problem hiding this comment.
I suggest using the new request.clientIp property instead of the PM variable. It will be easier to set up.
|
@evan-hughes, Thank you for reviewing it. I changed it. |
evan-hughes
requested changes
Oct 16, 2024
There was a problem hiding this comment.
It looks like other examples have a copyright in the main.js, e.g. the mPulse currency converter.
Please add a copyright statement in the main.js.
|
A copyright statement is added. |
evan-hughes
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New example of IP blocking