game of thrones quotes #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akanshSirohi
requested changes
Oct 10, 2024
|
@akanshSirohi done sir |
akanshSirohi
requested changes
Oct 11, 2024
|
@akanshSirohi done sir 😸😺 |
There was a problem hiding this comment.
@HritvikBhatia Check the line 67, you have added some extra text ":wq" looks like you were trying to use vim. I have fixed it but please check your PR from next time properly.
akanshSirohi
approved these changes
Oct 12, 2024
akanshSirohi
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal: #76
Changes Made
Added a JSON file containing 100 quotes from Game of Thrones.
Created a display card section to render the quotes on the page.
closes #76