Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When connecting with a nickname already in use, the new user doesn't actually connect or join #23

Open
lancelakey opened this issue Nov 30, 2011 · 2 comments
Assignees
Labels

Comments

@lancelakey
Copy link
Contributor

This is an awesome project. Thanks for this.

If I use web-irc to connect to a server with nick "lance" and any channel(s) and that nick is already in use I won't get any warning messages I'll just be presented with a web-irc UI with only a status tab which doesn't respond to any commands. I won't have joined any channels. If I try to /join #channel nothing will happen in the UI.

I was able to reproduce this using the only 2 servers I tried with, my own IRC server, and irc.freenode.net

This is easy to work around when connecting to my private IRC server, I just won't use a nickname I know is already in use.

If you need any details from me, logs, whatever, just ask. Thanks.

@ghost ghost assigned akavlie Nov 30, 2011
@akavlie
Copy link
Owner

akavlie commented Nov 30, 2011

Thanks for the bug report!

I found that this is caused by an upstream issue (in node-irc); there was no event for the nick change being sent. I added that in, and submitted a pull request for node-irc; hopefully it's merged in soon. I'll comment and close once there's a new version of node-irc with that fix.

@akavlie
Copy link
Owner

akavlie commented Nov 30, 2011

I should add that the node-irc fix prevents the app from breaking horribly, but we still need to add something in web-irc for user feedback about the nick change.

Looking at Colloquy as an example, they just log the nick change in the console. I think we should do this at a minimum, but something else might help it stand out to the user more. Have any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants