Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor setInterval to Observable.interval #63

Open
ghost opened this issue Nov 8, 2017 · 0 comments
Open

Refactor setInterval to Observable.interval #63

ghost opened this issue Nov 8, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Nov 8, 2017

I'm submitting a ... (check one with "x")

[ ] bug report => check the FAQ and search github for a similar issue or PR before submitting
[ ] support request => check the FAQ and search github for a similar issue before submitting
[x] feature request

Current behavior
Intervals are executed using setInterval().

Expected/desired behavior
Intervals use RxJS Observable.interval().

What is the motivation / use case for changing the behavior?
It's best practice. Also, Subscription is a more "Angular way" and can be used to terminate the interval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants