Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build not failing on detekt error #25

Open
hbmartin opened this issue Apr 2, 2021 · 2 comments
Open

Build not failing on detekt error #25

hbmartin opened this issue Apr 2, 2021 · 2 comments

Comments

@hbmartin
Copy link

hbmartin commented Apr 2, 2021

Hi, thanks for this project.
I have the following settings in my config:
fail_on_error: true
reviewdog_level: error

But even tho detekt is failing reviewdog still shows a pass:
https://github.com/hbmartin/protobuf_java_to_protobufjs/runs/2255365060?check_suite_focus=true

Am I doing something wrong configuring this?

@dawidhyzy-ifolor
Copy link

I face the same issue, did you figure it out?

@alsutton
Copy link

This should be solvable using a new public release of reviewdog... soon... when they make it.

We've created our own fork, with a prerelease reviewdog, which at https://github.com/snappautomotive/Detekt-Action so folk can see what's involved. I'm not submitting a PR for this repo because it relies on a custom created version of reviewdog, and it'd be better to wait for the full release, but if you really need to use that functionality feel free to use our fork until the feature has been upstreamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants