Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refreshing <entity unknown.unknown=unknown> in debug log #2699

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

danielbrunt57
Copy link
Collaborator

@danielbrunt57 danielbrunt57 commented Nov 28, 2024

This cleans up a media_player DEBUG log entry.
Before:

DEBUG (MainThread) [custom_components.alexa_media.media_player] d****l@b******a: Refreshing <entity unknown.unknown=unknown>

After:

DEBUG (MainThread) [custom_components.alexa_media.media_player] d****l@b******a: Refreshing: Garage Echo Dot

danielbrunt57 and others added 2 commits November 28, 2024 07:16
Fixes:
DEBUG (MainThread) [custom_components.alexa_media.media_player] d****l@b******a: Refreshing <entity unknown.unknown=unknown>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12071597222

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 10.006%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/alexa_media/media_player.py 0 1 0.0%
Totals Coverage Status
Change from base Build 11876654245: 0.0%
Covered Lines: 344
Relevant Lines: 3438

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12071593420

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 228 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 10.006%

Changes Missing Coverage Covered Lines Changed/Added Lines %
custom_components/alexa_media/media_player.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
custom_components/alexa_media/media_player.py 228 0.0%
Totals Coverage Status
Change from base Build 11876654245: 0.0%
Covered Lines: 344
Relevant Lines: 3438

💛 - Coveralls

@alandtse
Copy link
Owner

I have no idea what you're fixing.

@danielbrunt57
Copy link
Collaborator Author

danielbrunt57 commented Nov 28, 2024

Sorry, In DEBUG log, it used to say this:

2024-11-28 14:51:20.220 DEBUG (MainThread) [custom_components.alexa_media] Completing remaining startup tasks.
2024-11-28 14:51:26.474 DEBUG (MainThread) [custom_components.alexa_media.media_player] d****l@b******a: Refreshing: <entity unknown.unknown=unknown>
2024-11-28 14:51:26.475 DEBUG (MainThread) [custom_components.alexa_media.media_player] d****l@b******a: Garage Echo Dot: Last_called check: self: G************ETC reported: G************6SA
2024-11-28 14:51:26.475 DEBUG (MainThread) [alexapy.alexaapi] d****l@b******a: Trying get: https://alexa.amazon.ca/api/np/player?deviceSerialNumber=G0911M1002020ETC&deviceType=A1RABVCI4QCIKC&screenWidth=2560&_=1732834286475 : with uri: /api/np/player data None query {'deviceSerialNumber': 'G0911M1002020ETC', 'deviceType': 'A1RABVCI4QCIKC', 'screenWidth': 2560, '_': 1732834286475}

With this change, it looks like this:

2024-11-28 14:51:20.220 DEBUG (MainThread) [custom_components.alexa_media] Completing remaining startup tasks.
2024-11-28 14:51:26.474 DEBUG (MainThread) [custom_components.alexa_media.media_player] d****l@b******a: Refreshing: Garage Echo Dot
2024-11-28 14:51:26.475 DEBUG (MainThread) [custom_components.alexa_media.media_player] d****l@b******a: Garage Echo Dot: Last_called check: self: G************ETC reported: G************6SA
2024-11-28 14:51:26.475 DEBUG (MainThread) [alexapy.alexaapi] d****l@b******a: Trying get: https://alexa.amazon.ca/api/np/player?deviceSerialNumber=G0911M1002020ETC&deviceType=A1RABVCI4QCIKC&screenWidth=2560&_=1732834286475 : with uri: /api/np/player data None query {'deviceSerialNumber': 'G0911M1002020ETC', 'deviceType': 'A1RABVCI4QCIKC', 'screenWidth': 2560, '_': 1732834286475}

I've edited my first comment to be clearer.

@alandtse alandtse merged commit 22806c3 into alandtse:dev Nov 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants