[linux] Combat messages show %s character

[odsquad64]

When attacking the cave rats at the beginning of the game it shows the message "She looks: %s. Unhurt." It seems like "Unhurt" is supposed to replace the "%s" there. After attacking the rats once it changes to "She looks: %s. Wounded." Attacking some lesser mole rats later on I get the same message. I've searched but I haven't had any luck finding any mention of anyone else experiencing this issue.

[GBPlayer88]

Can confirm the bug in Windows too.

[trevorknight]

And MacOS

[dje4321]

From my PR #185 there were atleast 2 snprintf calls that did not provide the format specifier. I wonder if there are more missing/incorrect specifiers in the code

[hippydave]

From my PR #185 there were atleast 2 snprintf calls that did not provide the format specifier. I wonder if there are more missing/incorrect specifiers in the code

Thanks! From a quick search for sprintf, I think obj_examine_func is the relevant function.

[dje4321]

Ive found part of the issue and have confirmed a partial patch to resolve it.

at src/game/protinst.cc:423 there is this line of code
snprintf(formattedText, sizeof(formattedText), v66.text, v63.text, hpMessageListItem.text);
v66.text contains "%s %s."
v63.text contains "He Looks: %s."
hpMessageListItem.text contains "Unhurt"

It appears the code author is trying to use v66 as a recursive format specifier for v63 and hpMessageListItem but v63 already contains the needed format specifier for hpMessageListItem to be used properly. Just removing v66 format and allowing v63 to be used in its place seems to resolve the issue with my limited testing.

Pic from GDB confirming the issue

Ill probably submit a PR to fix this issue at some point once I can get a good look over the function to try and find any other locations that could be wrong. However this codebase is absolute ass to (look at/work on) with the most non-descript names imaginable so dont hold your breath

[dje4321]

I have merged this PR (and several others for bug fixes) into my git repo for those who are interested. You will be required to compile it yourself as I dont want to setup github CI for this

https://github.com/dje4321/fallout1-ce/tree/PR-Merge