Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid shelling to blkid #1

Open
alexeldeib opened this issue Apr 11, 2020 · 0 comments
Open

avoid shelling to blkid #1

alexeldeib opened this issue Apr 11, 2020 · 0 comments

Comments

@alexeldeib
Copy link
Owner

This line matches on output instead of the success of the command because I struggled to differentiate blkid itself failing, and blkid failing to find a partition on the disk (but executing successfully).

Ideally we remove any std::process::Command stuff, and read from one of several sources (not sure where the right data is):

  • /sys/block/*
  • /dev/disk/by-uuid -> read symlinks to /dev/sdxx
  • /etc/mtab -> partition data
@alexeldeib alexeldeib added good first issue Good for newcomers and removed good first issue Good for newcomers labels Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant