Updated GetClientArch to use runtime package instead of uname checks.

[Johannestegner]

Description

This pull request adds a env_windows.go file which will only be included when built for windows targets (+build and go:build directives added in both files).
The new file makes use of the runtime lib to fetch architecture and OS instead of relying on executing uname and parsing the result.

Motivation and Context

The primary motivation for this PR is the discussion in #977, and the fact that using goos/goarch will allow for the values resolving fine on windows without the use of the git bash tool.

How Has This Been Tested?

This has been tested by building (make dist) the binaries, then transferring them to the following platforms: darwin-arm64, darwin-amd64, linux-amd64, linux-armv7l, linux-arm64 .

Running arkade get --help to see the resulting architecture and OS resolved as the default variables.

Running arkade get <application> and see that windows is not supported while on supported platforms, the application is downloaded correctly.

Remarks

The implementation will for now return ming instead of windows, this to keep the currently created applications installable on windows computers.
Change will hence have no breaking change, while it might be an idea to, in the future, update applications for windows to target windows and keep ming separated for applications that actually requires ming.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have tested this on arm, or have added code to prevent deployment

[alexellis]

I'm sorry but this is not what I was asking for.

There should be a separate version of GetClientArch() which is combined only for Windows which looks at runtime.GOOS and returns the correct value. It could even be hard-coded given that it will only build in for Windows.

Then leave the existing code as it is for "unix"

Here's an example of how it works in Go: https://dave.cheney.net/2013/10/12/how-to-use-conditional-compilation-with-the-go-build-tool

[Johannestegner]

Ahh, I must have misunderstood, will fix asap! :)

[Johannestegner]

PR updated and Type changed to Breaking (see "remarks" in description).

Further, I included both go:build and +build directives, I'm not 100% sure this is needed, but wanted to make sure I don't break the build (let me know if the old +build directive should be removed).

[alexellis]

Although this PR allows for usage of other terminals than git-bash/ming in windows, this will make the ming target break, this due to the fact that earlier, the uname command determined if it was windows with ming while any terminal on windows now will return windows.

This will most likely require the ming check to be removed and replaced with a windows check (should this be included in this pull request)?

What if MING was returned from the function instead of "windows"?

Otherwise, it'd require a lot of search and replace and testing to make sure we'd covered all the various templates and their unit tests.

[Johannestegner]

What if MING was returned from the function instead of "windows"?

This could work, as long as the application downloaded doesn't actually require ming.
It could be a decent first step at the least.

From looking at the list of applications supported on windows in arkade, it seems like most runs fine in the standard terminal as well. And worst case, someone will report a bug.

This could also possibly remove the "breaking change" part, as it would work just as before for ming users.

[Johannestegner]

Replaced return value with hardcoded ming string, tested and it works fine both in windows terminal as well as git-bash :)

λ .\arkade.exe get yq
Downloading: yq
2023/10/24 09:06:06 Looking up version for yq
2023/10/24 09:06:07 Found: v4.35.2
Downloading: https://github.com/mikefarah/yq/releases/download/v4.35.2/yq_windows_amd64.exe

Kinda want to leave a comment about it being used like that to keep application installations working as they are... If you want me to add that, please let me know :)