New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid false positive when slices are pre-allocated #25

Open

zlasd opened this issue Aug 27, 2023 · 0 comments · May be fixed by #26

zlasd commented Aug 27, 2023

If a pre-allocated slice is declared by var statement and explicit type, it would be incorrectly reported as a candidate for pre-allocation.

For instance, the code snippet following would be reported.

package main

func main() {
	var s []int = make([]int, 0, 100)
	for i := range "Hello" {
		s = append(s, i)
	}
}

// Output:
// .\testdata\sample.go:4 Consider preallocating s

The text was updated successfully, but these errors were encountered:

zlasd linked a pull request

that will close this issue

Skip pre-allocated slices #26

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment