Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "disjunction" #216

Open
turion opened this issue Sep 22, 2022 · 1 comment
Open

Implement "disjunction" #216

turion opened this issue Sep 22, 2022 · 1 comment

Comments

@turion
Copy link
Contributor

turion commented Sep 22, 2022

There is conjunction, which is helpful, but there is no corresponding function generalizing or.

@alfert
Copy link
Owner

alfert commented Sep 23, 2022

That is an interesting idea. conjunction is implemented in proper as specific part of all properties, including data generation etc (starting here: https://github.com/proper-testing/proper/blob/bfd7d862dd5082eeca65c192a7021d0e4de5973e/src/proper.erl#L1151).

I assume (gut feeling only) that a disjunction makes dealing with counterexamples and shrinking way more difficult and for this reason it is not implemented. I would suggest to discuss with the people from Proper. If they add it to their execution engine, I am happy to include it here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants