TypeScript modelsv2 interfaces are incorrect

[joe-p]

Subject of the issue

I noticed that the TypeScript interface for algosdk.modelsv2.Account is incorrect. The interface uses camel-case keys (createdApps) but the actual object uses hyphenated keys (created-apps).

I haven't thoroughly looked (yet), but I assume this also affects some other algosdk.modelsv2 interfaces. I know for sure there are multiple incorrect keys for algosdk.modelsv2.Account

Your environment

This was seen with 1.13.1 but it appears to be the same in develop

Steps to reproduce

1. Attempt to get createdApps parameter

Expected behaviour

Following the TypeScript interface (thus documentation/IntelliSense), you'd expect to the get the created apps for that account.

Actual behavior

createdApps property is always undefined

// @ts-ignore must be used followed by the usage of the created-apps key

What do we want the desired behavior to be? I assume we want the actual object to be transformed to use came-case keys to conform with common JavaScript practices.

[SilentRhetoric]

I would like to bump this issue so that the SDK can be more fully utilized to provide typed data responses out of the box for API calls.

[Eric-Warehime]

Yes I agree this is an issue. I think it's going to be resolved when we implement #771 I have an initial PR open working on returning typed responses for all of the client calls. One of the problems (not yet solved in the PR) is converting from the returned keys (with hyphens) to the camel case keys like you're calling out here.

The changes for this will probably end up going into a 3.0.0 version of the SDK since changing return types for client calls can break people not expecting it.

I'm going to close this issue in favor of tracking these in #771 for now.