Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest color-picker component #1496

Open
aaronmcdavid opened this issue Mar 11, 2024 · 3 comments
Open

Use latest color-picker component #1496

aaronmcdavid opened this issue Mar 11, 2024 · 3 comments
Assignees

Comments

@aaronmcdavid
Copy link

期望的新功能 (describe the expected new feature)

Switch from rc-color-picker to @rc-component/color-picker.

简述一下使用场景,便于开发者更好理解新功能的必要性 (describe your scenario for us to understand the need)

The version of rc-color-picker used by form-render is six years old. The same package is now being maintained as the package @rc-component/color-picker. To prevent dependency proliferation, the newer version should be used.

Nota bene: @rc-component/color-picker requires a react version of 16.9.0, which is higher than 16.8.0, the version currently required by form-render.

@lhbxs
Copy link
Collaborator

lhbxs commented Mar 22, 2024

I need to evaluate the differences between the two npm packages, especially in the Props properties.

@arlobelshee
Copy link

The old version of color-picker also brings in a transitive dependency on a deprecated version of core-js (through its dependency on @babel/common 6.

core-js declares it was deprecated due to a 10x performance problem and multiple issues and vulnerabilities, so this is likely a security issue.

@arlobelshee
Copy link

Even going to @rc-component/color-picker v 1.9 would get off of the obsolete core-js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants