Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Armenian #123

Open
jglaszka opened this issue Sep 6, 2023 · 2 comments
Open

Add support for Armenian #123

jglaszka opened this issue Sep 6, 2023 · 2 comments
Assignees
Labels

Comments

@jglaszka
Copy link
Collaborator

jglaszka commented Sep 6, 2023

https://github.com/allegro/tradukisto/wiki/How-to-start-contributing

@subhajit20
Copy link

@jglaszka hey, I want to help. can you give some more info about this issue?

@jglaszka
Copy link
Collaborator Author

jglaszka commented Sep 11, 2023

@subhajit20 Hi. Tradukisto is the library what converts numbers to human-readable words - for example from 14 to fourteen. This issue was created to add support for counting in Armenian language. Depending on how numeral system in armenian is similar to other languages (english, arabic, german, slavic) and how many exceptions it have - it can be easy or more demanding.

Implementing unit tests will be really helpful for you, I encourage you to create them first (TDD paradigm), before developing new changes in the code. You can run them in terminal with ./gradlew test or green button in Intellij code editor.

New language needs to have implementation for Container - in your case armenianContainer. Depending on how your language works, having conjugation, gender forms, custom chunking (typically divider is for 3 numbers) etc it may be needed to define more advanced container with custom implementations for counting, for example turkish. Tests will really be helpful for you to see if it needs custom implementations or not.

Also define Values - translations for base numers and for plural forms (thousands, millions etc).
Feel free to ask if you have more questions, I will try to help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants