Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin has stopped working with Visual Studio Code #61

Closed
hnra opened this issue Dec 12, 2023 · 3 comments
Closed

Plugin has stopped working with Visual Studio Code #61

hnra opened this issue Dec 12, 2023 · 3 comments

Comments

@hnra
Copy link
Contributor

hnra commented Dec 12, 2023

Has this plugin stopped working with Visual Studio Code (tested 1.83.1 and 1.85.0) for anyone else? I'm observing some weird behavior when switching between regular and ts-strict-ignore files where sometimes ignored files report strictness diagnostics and sometimes normal files do no report strictness diagnostics. There is also a tendency for vscode to hang indefinitely with "Loading IntelliSense status" which results in no new diagnostics being produced (seems the language service hangs).

At first I thought it was simply that the first file which requests diagnostics set the strictness of the rest of the session but it seems this is not the case.

Interestingly I do not observe these issues when using my fork where I'm experimenting with keeping a separate TS program in-memory instead of mutating the compiler options of the language service. The fork can be found here: https://github.com/hnra/typescript-strict-plugin. I have tested this fork out on a project with 100k+ LOC and it seems to work well and fixes these issues. I can open a PR if we want to discuss upstreaming the changes.

typescript-strict-plugin version: 2.2.1
TypeScript version: 5.3.3 and 5.2.2
Visual Studio Code: 1.83.1 and 1.85.0

@KostkaBrukowa
Copy link
Collaborator

Hey! If you already have a fork, you can add a PR to repository and I can test if it works - if it will work better for others we can merge it because it looks very promising
From my side - I'm not using vscode and we do not upgrade TS very often in our project so it's hard for me to tell if this plugin has gotten worse over the time

@hnra
Copy link
Contributor Author

hnra commented Dec 15, 2023

I have cleaned up my fork a bit and tested it out on some different types of projects. The PR is here: #62, please try it out.

@hnra
Copy link
Contributor Author

hnra commented Jan 30, 2024

#67 seems to fix this issue 🥳

@hnra hnra closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants