Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide strict quick info in plugin #69

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

hnra
Copy link
Contributor

@hnra hnra commented Feb 11, 2024

This PR overrides the getQuickInfoAtPosition function on the LS proxy object in the plugin. Quick info shows up e.g. when hovering your cursor over a variable (see screenshots). It is important to show the correct type here since this is a way to evaluate type functions.

Without override:

unstrict

With override:

strict

Copy link
Contributor

@heyimalex heyimalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran into this today, thank you for fixing!

@KostkaBrukowa KostkaBrukowa merged commit a5990b7 into allegro:master Feb 19, 2024
3 checks passed
@KostkaBrukowa
Copy link
Collaborator

Thanks for cotribution! Published with 2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants