Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String not supported for Triotn #54

Open
amirhmk opened this issue Apr 18, 2023 · 1 comment
Open

String not supported for Triotn #54

amirhmk opened this issue Apr 18, 2023 · 1 comment

Comments

@amirhmk
Copy link
Contributor

amirhmk commented Apr 18, 2023

Have been working on model ensemble, continuing conversations from #53, just thought it may be a better idea to create new issues for different things that I find along the way. Essentially we want the output of the model be a S3 path where all the results are saved to as a JSON.

However it doesn't seem like clearml-serving is mapping object datatype properly? Triton does support strings..

The issue lies here I believe: np_to_triton_dtype. This currently maps an object to TYPE_BYTES to be written to the config.pbtxt file (which is not a valid type as per link above), whereas it should be TYPE_STRING.

@ainoam
Copy link

ainoam commented May 15, 2023

Always a good idea to separate issues @amirhmk, Thanks!

np_to_triton_dtype actually comes from triton itself.

Would you like to offer them a fix? It should be something like

    elif np_dtype == str:
        return "STRING"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants