Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change loopback address to anywhere #13

Closed
wants to merge 1 commit into from

Conversation

JakeJungJoonYoon
Copy link

Regarding Issue #12 which can be accessed by below link,
#12 (comment)

I have made quick PR which is changing lookback address (127.0.0.1) to anywhere address (0.0.0.0).

Thanks.

@jkhenning
Copy link
Member

Hi @JakeJungJoonYoon ,

Sorry for the late reply 🙏

This seems great, however since by default clearml-session is designed to be secure and only open these ports for the local network, than set up an SSH tunnel on top. If you'd like this as an option, I suggest it to be a configurable option (i.e. a command-line switch to the command-line tool) that, only if explicitly provided, will cause the code inside the container to use 0.0.0.0 instead of 127.0.0.1

@jkhenning
Copy link
Member

@JakeJungJoonYoon, is this PR still relevant?

@jkhenning jkhenning closed this Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants