Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change loopback address to anywhere #13

Closed
wants to merge 1 commit into from
Closed

change loopback address to anywhere #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clearml_session/interactive_session_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ def start_vscode_server(hostname, hostnames, param, task, env):
"--auth",
"none",
"--bind-addr",
"127.0.0.1:{}".format(port),
"0.0.0.0:{}".format(port),
"--user-data-dir", user_folder,
"--extensions-dir", exts_folder,
"--install-extension", "ms-toolsai.jupyter",
Expand Down Expand Up @@ -374,7 +374,7 @@ def start_vscode_server(hostname, hostnames, param, task, env):

proc = subprocess.Popen(
['bash', '-c',
'{} --auth none --bind-addr 127.0.0.1:{} --disable-update-check {} {}'.format(
'{} --auth none --bind-addr 0.0.0.0:{} --disable-update-check {} {}'.format(
vscode_path, port,
'--user-data-dir \"{}\"'.format(user_folder) if user_folder else '',
'--extensions-dir \"{}\"'.format(exts_folder) if exts_folder else '')],
Expand Down Expand Up @@ -437,7 +437,7 @@ def start_jupyter_server(hostname, hostnames, param, task, env):
"--no-browser",
"--allow-root",
"--ip",
"127.0.0.1",
"0.0.0.0",
"--port",
str(port),
],
Expand Down