Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downloading error when running evaluation #3

Open
HeZhao0122 opened this issue Nov 18, 2024 · 6 comments
Open

downloading error when running evaluation #3

HeZhao0122 opened this issue Nov 18, 2024 · 6 comments

Comments

@HeZhao0122
Copy link

Hi, when I try to run the evaluation follow the given example and your code, there is a problem on downloading data from github, id there any solutions?

image

@HeZhao0122
Copy link
Author

specifically, fail to run:

return prior.load_dataset(
"procthor-objaverse-internal",
revision="local",
path_to_splits=None,
split_to_path={
k: os.path.join(OBJAVERSE_HOUSES_DIR, f"{k}.jsonl.gz")
for k in ["train", "val", "test"]
},
max_houses_per_split=max_houses_per_split,
)[subset_to_load]

in PoliFormer/online_evaluation/online_evaluator.py

@KuoHaoZeng
Copy link
Collaborator

Hello! It requires the user to

  1. download asserts, annotations, and objaverse houses using this
  2. export the assets and houses dir to environments variable using this

Please find the screenshot for an example.
Screenshot 2024-11-18 at 10 34 30 AM

@HeZhao0122
Copy link
Author

Hi, thanks for your reply! I have download the asssets and others and export the path into the environment, then I run your example. It still receives the same error.
image

@HeZhao0122
Copy link
Author

when I tried to change the dataset info as

return prior.load_dataset(
dataset="spoc-data",
entity="spoc-robot",
revision="local-objaverse-procthor-houses",
path_to_splits=None,
split_to_path={
k: os.path.join(OBJAVERSE_HOUSES_DIR, f"{k}.jsonl.gz")
for k in ["train", "val", "test"]
},
max_houses_per_split=max_houses_per_split,
)[subset_to_load]
,which is found in the spoc project
it can run normally. Are the two version the same dataset?

@KuoHaoZeng
Copy link
Collaborator

KuoHaoZeng commented Nov 21, 2024

Yes, they should be the same (please see the screenshot)!
Thank you for finding this bug! I believe it is because the prior.load uses my github token to load data from internal storage, but not from the public space, using the way I loaded houses.
I'll update the script.

Screenshot 2024-11-21 at 3 50 42 PM

@HeZhao0122
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants