Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify manuall loop unrolling in BlockThreadReduceKernel and overwork it #43

Open
SimeonEhrig opened this issue Oct 27, 2021 · 0 comments
Open

Verify manuall loop unrolling in BlockThreadReduceKernel and overwork it #43

SimeonEhrig opened this issue Oct 27, 2021 · 0 comments
Milestone
release 0.2

Comments

@SimeonEhrig
Copy link
Member

There is comment BlockThreadReduceKernel, that the manual unrolling is not tested.

vikunja/include/vikunja/reduce/detail/BlockThreadReduceKernel.hpp

Line 114 in b3e3dc3

// Manual unrolling. I dont know if this is really necessary, but

This should be done and @bernhardmgruber mentioned in the PR #40 that some parts could be illegal and provide some improvements, also for the readability.

Related to the topic: #40 (comment)
@SimeonEhrig SimeonEhrig added this to the release 0.2 milestone Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release 0.2
Development

No branches or pull requests
1 participant
@SimeonEhrig