Build Properties #331
Open
Build Properties #331
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzleutgeb
force-pushed
the
build-properties
branch
from
c7c701d
to
1293c40
Compare
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
============================================
- Coverage 70.23% 70.15% -0.08%
Complexity 2123 2123
============================================
Files 182 182
Lines 8023 8036 +13
Branches 1423 1424 +1
============================================
+ Hits 5635 5638 +3
- Misses 2028 2037 +9
- Partials 360 361 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Works as expected so far, -version CLI flag correctly outputs build.properties content.
However, we have duplicate zip entries for the build.properties file (gets created once by each module). This has two immediate consequences:
- Our jar files become invalid for
unzip, i.e. unzipping of the bundled jar is no longer possible (see this issue for some background information) due to these duplicate entries. - In a setting where different modules of alpha get packaged into one jar that do not share the exact same version, an overwrite-strategy for duplicate handling would destroy information (likelyhood of that seems pretty low).
While I'm not too concerned about the second item, I think we do need a fix for the invalid zip issue.
|
Right. Thanks for catching this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a mechanism to pass "Build Properties" (version number, hash of the source revision, etc.) to the resulting artifact. Mainly to allow Alpha report its own version, which is implemented as example.
This contents of
META-INF/build.propertiesmust be kept reproducible, i.e. only depend on our Git repository as input, not use timestamps, current hostname or weather...