Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching "(not) done" when using :todo #267

Open
Walheimat opened this issue Oct 1, 2024 · 2 comments · May be fixed by #268
Open

Matching "(not) done" when using :todo #267

Walheimat opened this issue Oct 1, 2024 · 2 comments · May be fixed by #268
Assignees
Milestone

Comments

@Walheimat
Copy link

OS/platform

Linux

Emacs version and provenance

Emacs 30.0.60, make

Org version and provenance

9.7.5, included in Emacs 30.0.60

org-super-agenda package version and provenance

20240916.1753, MELPA

Description

I don't use the same org-todo-keywords across all of my agenda files. Currently I can just match :todo with nil, t or a specific string. But "done" might be "constructed" or "read" in certain files.

What would be really nice is to say :todo done or :todo not-done and then match against any "(not) done" item.

Org has buffer-local org{-not}-done-regexp. Not sure how easy (or if it all possible) this could be used to enable this.

Etc.

No response

@alphapapa
Copy link
Owner

Hi Krister,

Yes, this is a good idea. From the filtering side, Org QL provides this, as you can write a query like (not (done)) or (todo) (they are equivalent), but somehow I didn't think to provide the same for org-super-agenda.

The implementation should be relatively straightforward; existing code in this package and org-ql should provide helpful examples. I probably won't have time to work on this soon, so patches welcome in the meantime.

Thanks.

@alphapapa alphapapa self-assigned this Oct 1, 2024
@alphapapa alphapapa added this to the 1.4 milestone Oct 1, 2024
@Walheimat
Copy link
Author

Alright, cool. I'll see if I can implement this the way you suggested and then open a PR.

@Walheimat Walheimat linked a pull request Oct 3, 2024 that will close this issue
@alphapapa alphapapa linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants