-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add languages icons #351
Comments
Need to retest as Harry and I saw this icon after uploading files with the right languages and also after we said yes to all in the language pop-up. |
Yep, thanks again for fitting in such a productive chat Sent from my BlackBerry 10 smartphone. From: monzugSent: Thursday, April 29, 2021 6:02 PMTo: alpheios-project/alignment-editor-newReply To: alpheios-project/alignment-editor-newCc: Harry Diakoff; MentionSubject: Re: [alpheios-project/alignment-editor-new] Add languages icons (#351)
Need to retest as Harry and I saw this icon after uploading files with the right languages and also after we said yes to all in the language pop-up.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#351 (comment)",
"url": "#351 (comment)",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
tested in Alpheios Translation Alignment editor 1.3.3 (build development.20210430.74) |
Monica - I was not able to reproduce your result. Could you point what are doing the other way - and getting your failed result? |
Monica, could describe me exact clicks for such cases? |
I could not reproduce it in updated application |
I did enter text in both enter text boxes as per example 1) and language was Eng or EPO or Dan respectively. I did also try with amo, amas, amat, amamus, amatis, amant but the language was set to French not to Latin.
|
Will check later |
to repro the missing language icons as per previous comment:
|
Arabic and Greek texts have both the no language is detected icon (this is a full json file that has been uploaded after passing a prior check on languages and saved with grc and ara in the file name) see zip file below |
from @balmas 's email: |
I think it is not as easy as you describe in the comment.
On what step should application decide that final result is not properly and should use check by char code? And also I should point again - that we check only plain texts - we don't try to detect TEI texts. |
I don't have enough information to check the detection service and icon.
For now I could check only the following scenarios described by Monica (when I would have priority for this)
In this case - I should suppress icon, because we don't detect text uploaded from JSON. If to be honest from my point of view - detection service works well and I like it, I didn't face with problems with it in normal workflow - paste text or enter it - detection goes well. |
I do not think it does work well and that's part of the reason I was
suggesting to suppress the detection icon, at least.
as per the Amharic versus Geez, it's easy to repro: enter the following
line of plain text in the original box: ሰርከ፡ እንከ፡ እንዘ፡ ናአኵት፡ እስመ፡ ለነ፡
ዕረፍተ፡ ወሀበ፡ ሌሊተ፡
and you'll see that language is set to Amharic.
if it's Amharic or Geez, that I do not not really know but the text comes
from DTSAPI
…On Mon, Jun 14, 2021 at 2:44 PM Sklyarova Irina ***@***.***> wrote:
@balmas <https://github.com/balmas> , @abrasax
<https://github.com/abrasax> , @monzug <https://github.com/monzug>
I don't have enough information to check the detection service and icon.
We could have here several cases:
-
you could give me reproducable text samples (in correct char codes -
not screenshots) - that give wrong detection result (you are not agreed
with this result), I would check full answer from the service (isReliable,
confidence) - and then we could discuss such exceptions of the service
-
may be such problems could happen from service availability failure (I
didn't face it myself), then I need screenshot with the error from browser
console / network tab - and we could decide how to handle with such failure
For now I could check only the following scenarios described by Monica
(when I would have priority for this)
to repro the missing language icons as per previous comment:
1. generate an error by uploading an unsupported file type (as json
file from choose file)
2. enter text or copy text in Original and Translations boxes.
3. you will notice that the Original box is missing the Language icon
and Text or Tei icon
Arabic and Greek texts have both the no language is detected icon (this is
a full json file that has been uploaded after passing a prior check on
languages and saved with grc and ara in the file name)
In this case - I should suppress icon, because we don't detect text
uploaded from JSON.
------------------------------
If to be honest from my point of view - detection service works well and I
like it, I didn't face with problems with it in normal workflow - paste
text or enter it - detection goes well.
That's why we should check exceptions and only after that decide that this
icon doesn't work properly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#351 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ32UOPGMO6TVK2H2V3NCBDTSX2SZANCNFSM43ZLTL5A>
.
|
Detection service gives the following result And you are right this service doesn't detect text correctly - it shows very low confidence and isRelieble === false So if we had such a result from teh service - we could do additional check. But @monzug , how we could get Serbian from such a text? Do you have such text samples? |
When it was first implemented, I remembered that I was getting a lot of
eastern european languages (Sebian, Polish, etc). I might still have some
screenshots from the past. Could it be that you were using a different
service that was weighted based on location or language used?
…On Mon, Jun 14, 2021 at 3:00 PM Sklyarova Irina ***@***.***> wrote:
Detection service gives the following result
(we use this - https://detectlanguage.com/ it has a demo textArea to test
texts manually)
[image: image]
<https://user-images.githubusercontent.com/12377640/121895788-f45b1b80-cd63-11eb-9e19-82e5ebb91371.png>
And you are right this service doesn't detect text correctly - it shows
very low confidence and isRelieble === false
So if we had such a result from teh service - we could do additional check.
But @monzug <https://github.com/monzug> , how we could get Serbian from
such a text? Do you have such text samples?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#351 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ32UOOPNC4D42ZHWKAEX6TTSX4OZANCNFSM43ZLTL5A>
.
|
No, I didn't change the service - we always use https://detectlanguage.com/ And I don't really think that definition by char code manually or other services are really better for most cases. As I could see from the list of supported languages - https://detectlanguage.com/languages We could test this service more widely and correctl- with checking confidence and reliable properties in the answer for different samples of the text. We discussed it with @abrasax , and he told that we don't want to spend much time for language detection. |
what's left on this issue is:
I was not able to reproduce the 'ergo sum magistris' set to English, it was latin in my latest tests. |
when I went back to the align screen all the remaining portions and tiles
were gone. Definitely a bug. Definitely has to be addressed before we give
it to anyone.
|
I think this comment belong to issue #503 |
from online meeting with @abrasax
Add
no langauge is detected
icon - when the language was not detected by service or there is too less characters for detection (less then 5)Add language code above text box
The text was updated successfully, but these errors were encountered: