Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm am parsing #12

Open
umerhasan17 opened this issue Feb 16, 2020 · 4 comments
Open

pm am parsing #12

umerhasan17 opened this issue Feb 16, 2020 · 4 comments

Comments

@umerhasan17
Copy link
Contributor

I would like for the program to recognise the current time of day and if I specify a time before this without any other parameters such as 'today' or 'tomorrow'. I think the default should be it goes to tomorrow. For example, "Remind me at 1 pm" or "Set an alarm for 7 am" should default to tomorrow at 1 pm if the current time is 5 pm for example.

This is another minor bug but I would like to solve it. When the string '5 o'clock pm' is entered this results in a value error when the program tries to parse '5 o'clock' as an integer.

What do other people think of both these problems?

image

@umerhasan17
Copy link
Contributor Author

@alvinwan

@alvinwan
Copy link
Owner

@umerhasan17 That sounds good. If you could file separate PRs (o'clock v. am/pm), I can take a look. The default for "Monday" is "next Monday," so what you said for am/pm would only make sense.

@umerhasan17 umerhasan17 mentioned this issue Feb 19, 2020
@umerhasan17
Copy link
Contributor Author

@alvinwan I created the PR for the simpler fix and working on the other one. Can you explain why the coverage drops because of the extra 3 lines? Thank you.

@alvinwan
Copy link
Owner

Hey @umerhasan17, nice work! The coveralls bot reply in your PR #13 (comment) provides a link timefhuman/categorize.py that shows which lines are not covered by tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants