dshot: check for bad pulses and handle wrap correctly #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-DShot-decode-fix2
branch
from
98b42b4
to
29f6090
Compare
freasy
approved these changes
Sep 13, 2024
tridge
force-pushed
the
pr-DShot-decode-fix2
branch
from
29f6090
to
51320bd
Compare
freasy
approved these changes
Sep 30, 2024
tridge
force-pushed
the
pr-DShot-decode-fix2
branch
from
51320bd
to
7f9c9de
Compare
this ensures we handle timer wrap correctly, fixing bad dshot frames
with ArduPilot, and also checks for much too narrow or wide pulses
by making variables static this also saves flash and ram. Using
REF_F031 as the benchmark we get:
current REF_F031:
Memory region Used Size Region Size %age Used
SRAM: 0 GB 192 B 0.00%
RAM: 3760 B 3904 B 96.31%
FLASH_VECTAB: 192 B 192 B 100.00%
FLASH_VERSION: 16 B 16 B 100.00%
FLASH: 23260 B 27408 B 84.87%
FILE_NAME: 32 B 32 B 100.00%
EEPROM: 0 GB 1 KB 0.00%
with this PR:
Memory region Used Size Region Size %age Used
SRAM: 0 GB 192 B 0.00%
RAM: 3704 B 3904 B 94.88%
FLASH_VECTAB: 192 B 192 B 100.00%
FLASH_VERSION: 16 B 16 B 100.00%
FLASH: 23244 B 27408 B 84.81%
FILE_NAME: 32 B 32 B 100.00%
EEPROM: 0 GB 1 KB 0.00%
so we save 54 bytes of ram and 16 bytes of flash, while fixing the
wrap issue and adding pulse width checks
tridge
force-pushed
the
pr-DShot-decode-fix2
branch
from
7f9c9de
to
f265ef6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new variant of #76
this ensures we handle timer wrap correctly, fixing bad dshot frames with ArduPilot, and also checks for much too narrow or wide pulses
by making variables static this also saves flash and ram. Using REF_F031 as the benchmark we get:
current REF_F031:
with this PR:
so we save 54 bytes of ram and 16 bytes of flash, while fixing the wrap issue and adding pulse width checks