Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update PR title instructions #994

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Jun 5, 2024

Issue #, if available:

Description of changes:
Instructions about commit messages should really refer to PR titles, since that's what ends up in the commit log.

Note - after getting approval and merging this, I'll make the same change in the several other Braket repos which contain this content in their CONTRIBUTING.md.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fb307e3) to head (0670f96).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #994   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines         8948      8948           
  Branches      2010      2010           
=========================================
  Hits          8948      8948           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Manvi-Agrawal
Copy link

Thanks a ton @rmshaffer for taking up this small change to improve the checklist and the CONTRIBUTING doc.

@rmshaffer rmshaffer marked this pull request as ready for review June 5, 2024 20:21
@rmshaffer rmshaffer requested a review from a team as a code owner June 5, 2024 20:21
@speller26 speller26 merged commit 9f6adcf into main Jun 27, 2024
26 checks passed
@speller26 speller26 deleted the rmshaffer/pr-title-instructions branch June 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants