ament_vendor() does not install vendor project to correct path

[felixf4xu]

Hi,

I'm building ros2/rosbag2/zstd_vendor and the cmake file is like:

ament_vendor(zstd_vendor
  SATISFIED ${zstd_FOUND}
  VCS_URL https://github.com/facebook/zstd.git
  VCS_VERSION v1.4.8
  SOURCE_SUBDIR build/cmake
  CMAKE_ARGS
    -DZSTD_BUILD_STATIC:BOOL=OFF
    -DZSTD_BUILD_SHARED:BOOL=ON
    -DZSTD_BUILD_PROGRAMS:BOOL=OFF
)

but the current result is that bin/include/lib are installed at C:\ros\rolling\install\opt\zstd_vendor

but by colcon build --merge-install, I think those 3 sub folders should be installed to C:\ros\rolling\install.

[felixf4xu]

oh, to fix the issue, I should change

install(
      DIRECTORY "${INSTALL_DIR}/"
      DESTINATION "opt/${PROJECT_NAME}"
      USE_SOURCE_PERMISSIONS
    )

to

install(
      DIRECTORY "${INSTALL_DIR}/"
      DESTINATION "${CMAKE_INSTALL_PREFIX}"
      USE_SOURCE_PERMISSIONS
    )

[jimmy-mcelwain]

I think that it would be nice if there was at least an option available that would install the vendor package install components into the install/include and install/lib directories rather than just putting it into opt. Prior to the change in ros2/libyaml_vendor#58, yaml.h and yaml.a would be installed in same directory as most other packages, not in opt.