-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 18 support? (Update package.json?) #116
Comments
This PR addresses React 18 support: #123 |
Any updates on this? @10xLaCroixDrinker @kylemcd |
@zedosan921 The PR is opened, just waiting on a yes / no from the maintainers. In the meantime you could install the React 18 version of the package to your project by adding this to your package.json
Safer option would definitely be to fork my repo and update the package to pull from there: https://github.com/kylemcd/react-albus Let me know if you have any question, at this point it seems highly unlikely that my PR gets merged in or the maintainers will update to support React 18 themselves. |
How much of that PR was to actively support React 18? My quick review didn't really show any code changes besides formatting updates, just the |
@smackfu As stated in the PR title, the intention was to make the package compatible with React 18. Additionally, compatibility with React 17 was also addressed, as it had been neglected. I have no intention of investing the time to fully integrate an abandoned repository to support the latest React technology. However, I would like to assist users like myself who are utilizing it in legacy projects and wish to upgrade their dependencies. Due to the warnings encountered during We have been successfully running my fork of |
This issue is stale because it has been open 30 days with no activity. |
Is there any update on this? |
This issue is stale because it has been open 30 days with no activity. |
Hello!
Thanks for making react-albus.
I'm using react-albus with react 18.
It's working as expected but we need to force the install (
npm i --legacy-peer-deps
).Indeed, peer dependencies allow react v15 or v16.
https://github.com/americanexpress/react-albus/blob/main/package.json#L79
I really like this project, but I have the impression that it is less and less active sadly.
The text was updated successfully, but these errors were encountered: