Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TWO logout buttons are displayed | q2a-open-login plugin (look at screen) #109

Open
bertrandgorge opened this issue Aug 27, 2019 · 1 comment
Open

TWO logout buttons are displayed | q2a-open-login plugin (look at screen) #109

bertrandgorge opened this issue Aug 27, 2019 · 1 comment

Comments

@bertrandgorge
Copy link

bertrandgorge commented Aug 27, 2019 •
edited
Loading

Hi
I installed the plugin q2a-open-login (Donut theme)
The drop-down menu displays TWO logout buttons
Top button (icon without text) is not active
The bottom (just text) works as it should.

How to unite buttons or remove the top icon?
I will be grateful for any help

https://www.question2answer.org/qa/65340/two-logout-buttons-displayed-open-login-plugin-look-screen?show=65340#q65340
@bertrandgorge
Copy link
Author

The problem comes from the fact that q2a-open-login makes it's own HTML for the logout button, and pushes is back in the label, which then contains an anchor tag. In user-loggedin-drop-down.php, another a tag is added, which breaks the HTML.

I will submit a patch that tests the content of the label for anchors before adding our own. Not great but robust.

bertrandgorge added a commit to NeayiAbandoned/Donut that referenced this issue Aug 27, 2019
@bertrandgorge
Upgraded Donut to match the new release of q2a-open-login
42de226 
buttons.less:
* Added a button-unlink (to remove login providers), with a white times sign in a red button
* Removed a trailing comma that was making lint not happy

header.less:
* Added a specific class to distinguish between user menu regular items and login buttons (the css was being mixed up)

user-loggedin-drop-down.php:
* Added a specific class to distinguish between user menu regular items and login buttons (the css was being mixed up)
* Added a test when showing the logout button, because in some case the label already contains the logout link, so it was creating a bizare double menu (see https://www.question2answer.org/qa/65340/two-logout-buttons-displayed-open-login-plugin-look-screen?show=65340#q65340) - see issue amiyasahu#109

user-login-drop-down.php:
* Removed all additional classes added to login buttons, because q2a-open-login does everything on its own now, with more providers, using bootstrap-social
* Added a specific class to distinguish between user menu regular items and login buttons (the css was being mixed up)
@bertrandgorge bertrandgorge mentioned this issue Aug 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bertrandgorge