Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

106 replace UUID with save set name #152

Merged
merged 25 commits into from
Dec 10, 2024
Merged

106 replace UUID with save set name #152

merged 25 commits into from
Dec 10, 2024

Conversation

engelharddirk
Copy link
Contributor

@engelharddirk engelharddirk commented Dec 10, 2024 •
edited
Loading

Replaces all visible ocurrences of the backup UUID with the backup saveset. Adds the saveset to the dtos in the analyzer module and backend, and adjusts the frontend accordingly.

Bildschirmfoto 2024-12-10 um 11 16 04

@engelharddirk
add saveset to analyzer
dd0ec01 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
use saveset in alert dtos
2bd4036 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
add saveset name to BackupDataEntity
a51dca4 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
Merge branch 'dev' into 106-replace-uuid-with-save-set-name
eb979c8
@engelharddirk
leave uuid in dto
12a1e2b 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
use proper type checking in analyzer file
0f1201f 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
leave uuid asis, just add saveset
f1b7b91 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
begin frontend adaptation
b1cbb5b 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
fix frontend test
b3d194e 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
add saveset name to table
ad83f09 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
refactor
694c65f 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
make sort and filter by saveset work
5e7db32 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
fix backend tests
2ae350c 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
use saveset in alert frontend
4a23d44 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
fix alert bug created in the process
d49706f 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
adapt some more frontend tests
653b752 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
remove uuid from frontend
7074fa2 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
fix alert bug created in the process
28566e9
@engelharddirk
some dev merge adjustments
7d27c5e 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
Merge branch 'dev' into 106-replace-uuid-with-save-set-name
60d2612
@engelharddirk
fix poetry lock
802226a 
Signed-off-by: engelharddirk <[email protected]>
flo0852
flo0852 previously requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@flo0852 flo0852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just some smaller things. Only had a little time. Will not be able to do a full Review

apps/backend/src/app/backupData/backupData.service.ts Outdated Show resolved Hide resolved
apps/frontend/src/app/alert/component/alert.component.html Outdated Show resolved Hide resolved
apps/frontend/src/app/backups-overview/backups/backups/backups.component.ts Outdated Show resolved Hide resolved
apps/frontend/src/app/backups-overview/backups/backups/backups.component.ts Outdated Show resolved Hide resolved
apps/analyzer/metadata_analyzer/creation_date_alert.py Outdated Show resolved Hide resolved
apps/analyzer/metadata_analyzer/creation_date_alert.py Outdated Show resolved Hide resolved
apps/analyzer/metadata_analyzer/size_alert.py Outdated Show resolved Hide resolved
apps/analyzer/metadata_analyzer/size_alert.py Outdated Show resolved Hide resolved
@engelharddirk
review changes
f426c90 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
fix analyzer tests
fd97e96 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
more review changes
7f9269e 
Signed-off-by: engelharddirk <[email protected]>
@engelharddirk
fix backend tests
4f042e1 
Signed-off-by: engelharddirk <[email protected]>
@Omega65536 Omega65536 self-requested a review December 10, 2024 14:20
Omega65536
Omega65536 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Omega65536 Omega65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; all changes proposed by @flo0852 were incorporated. Great work!

Omega65536

This comment was marked as duplicate.

Sign in to view

@flo0852 flo0852 dismissed their stale review December 10, 2024 14:54

All changes done

@engelharddirk engelharddirk merged commit 083159f into dev Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Omega65536 Omega65536 Omega65536 approved these changes

@flo0852 flo0852 flo0852 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engelharddirk @Omega65536 @flo0852