Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] UProbes & Symbols Search #157

Merged
merged 10 commits into from
Dec 11, 2024
Merged

[UI] UProbes & Symbols Search #157

merged 10 commits into from
Dec 11, 2024

Conversation

luca-dot-sh
Copy link
Contributor

This PR adds:

  • Split configuration screen in two sections and add uprobes selection
  • Symbols Screen for searching for symbols
  • Workaround for searching from backend
  • Product Mission to the About screen
  • Reset screen instead of unused Preset screen
  • Moving some composables to composables folders
  • remove duplicate code from Nav Graph
  • split into subpackages

Video:
uprobes_ui.webm

Closes #121

@luca-dot-sh
refactor: create subpackages in bl and api
325def9 
Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh
feat: split configuration screenm, add uprobe selection + add symbol …
a490f91 
…screen and searching

Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh
feat: replace presets with reset screen
3ef39d4 
Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh
feat: add product mission to about screen
da14855 
Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh
refactor: ktfmtFormat
68b3cc1 
Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh
feat: add symbol searching workaround + various small fixes
4604d9f 
Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh
refactor: simplify navgraph and ktfmtFormat
7fed569 
Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh
feat: add diffing uprobeconfig
57fee11 
Signed-off-by: Luca Bretting <[email protected]>
@luca-dot-sh luca-dot-sh requested a review from fhilgers December 10, 2024 22:59
@luca-dot-sh
fix: allow removing configs
b4fc5f9 
Signed-off-by: Luca Bretting <[email protected]>
fhilgers
fhilgers approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@fhilgers fhilgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenediktZinn BenediktZinn merged commit fa8ca9d into dev Dec 11, 2024
7 checks passed
@BenediktZinn BenediktZinn deleted the uprobes_frontend branch December 11, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktZinn BenediktZinn BenediktZinn approved these changes

@fhilgers fhilgers fhilgers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luca-dot-sh @fhilgers @BenediktZinn