From ba4469d51fb295ee67a52f728d456345e900df22 Mon Sep 17 00:00:00 2001 From: Matthias Rolke Date: Fri, 11 Oct 2019 09:29:07 +0200 Subject: [PATCH 1/2] test: temporarily disable tests for Sharing Scratch orgs with the Winter 20 release have different Organization-Wide Defaults (internal/external) set on Users and Individuals, making it impossible to simply deactivate External Sharing after activating it. --- src/plugins/security/sharing/index.e2e-spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/security/sharing/index.e2e-spec.ts b/src/plugins/security/sharing/index.e2e-spec.ts index 1cc5244e..cc41e8e2 100644 --- a/src/plugins/security/sharing/index.e2e-spec.ts +++ b/src/plugins/security/sharing/index.e2e-spec.ts @@ -3,7 +3,7 @@ import * as child from 'child_process'; import * as path from 'path'; import Sharing from '.'; -describe(Sharing.name, () => { +describe.skip(Sharing.name, () => { it('should enable', function() { this.timeout(1000 * 90); this.slow(1000 * 30); From d6d99d270dc4703e0d9b73e8cdaf0f3f13492fb9 Mon Sep 17 00:00:00 2001 From: Matthias Rolke Date: Fri, 11 Oct 2019 09:07:19 +0200 Subject: [PATCH 2/2] fix: encoding for URLs related to Critical updates When a Critical Update Name contained an ampersand symbol, the update could not be processed. --- src/plugins/company-settings/critical-updates/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/company-settings/critical-updates/index.ts b/src/plugins/company-settings/critical-updates/index.ts index dfa2f473..22ceb79b 100644 --- a/src/plugins/company-settings/critical-updates/index.ts +++ b/src/plugins/company-settings/critical-updates/index.ts @@ -4,9 +4,9 @@ import { BrowserforcePlugin } from '../../../plugin'; const PATHS = { BASE: 'ruac/ruacPage.apexp', - REVIEW: '/ruac/CriticalUpdateDetail.apexp?name=', - ACTIVATE: '/ruac/CriticalUpdateActivate.apexp?name=', - DEACTIVATE: '/ruac/CriticalUpdateDeactivate.apexp?name=' + REVIEW: 'ruac/CriticalUpdateDetail.apexp?name=', + ACTIVATE: 'ruac/CriticalUpdateActivate.apexp?name=', + DEACTIVATE: 'ruac/CriticalUpdateDeactivate.apexp?name=' }; const SELECTORS = { TABLE_BODY: 'tbody[id$=":featuresTable:tb"]', @@ -78,7 +78,7 @@ export default class CriticalUpdates extends BrowserforcePlugin { for (const update of config) { const url = `${ update.active ? PATHS.ACTIVATE : PATHS.DEACTIVATE - }${encodeURI(update.name)}`; + }${encodeURIComponent(update.name)}`; const page = await this.browserforce.openPage(url); const buttonSelector = update.active ? SELECTORS.FORM_ACTIVATE_BUTTON