fix(PeriphDrivers): Added update to force scale select sample to occur with ADC and ADC RefSelect for REVA API #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricB-ADI
requested review from
Jake-Carter,
sihyung-maxim and
EdwinFairchild
|
/clang-format-run |
github-actions
bot
added
MAX32570
EricB-ADI
changed the title
|
/clang-format-run |
github-actions
bot
added
the
Register Change
|
/generate-register-files |
Jake-Carter
approved these changes
Oct 24, 2023
|
Bot updated headers :/ |
|
/generate-register-files |
EdwinFairchild
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For chips with an ADC which allows for external voltage division, the scale select is only sampled after the channel select is switched to a new channel. So when using channel one, the external scale will not take effect since 0 is the default channel and is not switched even if configured. This fix forcefully toggles the channel selected anytime the ExtScale is set.
Also added is the API for ADC RefSelect for REVA