Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add better support of editor selection #247

Open
anb0s opened this issue Mar 29, 2022 · 0 comments
Open

add better support of editor selection #247

anb0s opened this issue Mar 29, 2022 · 0 comments
Assignees
Labels
breaking-change major version or breaking change enhancement
Milestone

Comments

@anb0s
Copy link
Owner

anb0s commented Mar 29, 2022

In the versions before pre-release v2.3.0-beta.2 the selection in editor was used to create new resource selection that just tried to find files and/or folders from selected text. The text was devided implicitly by line-endings and therefore it was sometimes not the wanted output.

With the new pre-release v2.3.0-beta.2 the text selections are not handled anymore as new resource selection but the text selection is stored in the resource object derived from the editor document resource (IResource or IFile). This was needed to implement #212 and #219 properly.

We need a special handling and options to have the resource selections configurable and explicit to avoid edge cases.

May be related to #166 and other issues that needs selection preprocessing or user dialog for explicit knowledge and decision from user.

@anb0s anb0s added enhancement breaking-change major version or breaking change labels Mar 29, 2022
@anb0s anb0s self-assigned this Mar 29, 2022
@anb0s anb0s added this to the TBD milestone Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change major version or breaking change enhancement
Projects
None yet
Development

No branches or pull requests

1 participant