Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use custom icons #97

Open
mstempell opened this issue Oct 1, 2016 · 8 comments
Open

Possibility to use custom icons #97

mstempell opened this issue Oct 1, 2016 · 8 comments
Assignees
Milestone

Comments

@mstempell
Copy link

Thanks for working on this. This new version is very usable (and the presets for ConEmu and T.C. are working just fine).

As a minor cosmetic enhancement request, could you add the possibility to use custom icons?

@anb0s anb0s added this to the v2.1 milestone Oct 1, 2016
@anb0s anb0s self-assigned this Oct 1, 2016
@anb0s
Copy link
Owner

anb0s commented Oct 1, 2016

Thanks! I've it already at my todo list. Actually the icons are bounded to categories. I can add icon selections for category, menu or command from embedded icons first...

@mstempell
Copy link
Author

mstempell commented Oct 2, 2016

True that the most flexible system for icons would be to have those bounded to menu entry, as these are displayed there.
And then being able to set different icons between every entry will help to target the desired one faster.

@anb0s
Copy link
Owner

anb0s commented Dec 18, 2016

Just investigated the solution and it needs some major changes to the icon handling. I want to release v2.1 in next days and think about moving this request to next v2.2 (2017-01/02) release...

@anb0s
Copy link
Owner

anb0s commented Dec 18, 2016

I see two solutions or steps:

  1. add dialog for selecting icon embedded in EasyShell --> only few (~20) icons are now there, can be done for next release
  2. user can also select icon from file system (outside or EasyShell plugin). We can store the path to the file, but have some error handling if the file is not there. Or copy the file to the eclipse workspace...

anb0s added a commit that referenced this issue Dec 27, 2016
added internal handling and override of images / icons

Signed-off-by: Andre Bossert <[email protected]>
@anb0s
Copy link
Owner

anb0s commented Dec 27, 2016

done internal work for image / icon handling and override (preparation for step 1.)

@anb0s
Copy link
Owner

anb0s commented Dec 27, 2016

see #136 for the step 1.

@mstempell
Copy link
Author

The envisioned additions are great.
Also copying selected external icons in the workspace would be perfect, as those will probably come from a temporary ("downloaded" in many cases) storage.
Thanks for working on this again.

@anb0s anb0s modified the milestones: v2.2, v2.1 Feb 14, 2017
@anb0s
Copy link
Owner

anb0s commented Feb 14, 2017

#136 will be done in v2.1 and this one moved to v2.2

@anb0s anb0s modified the milestones: v2.2, TBD Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants