Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cvss 4.0 #1970

Open
tomersein opened this issue Jul 1, 2024 · 8 comments
Open

support cvss 4.0 #1970

tomersein opened this issue Jul 1, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@tomersein
Copy link
Contributor

What would you like to be added:
hello!
NVD announced they support cvss 4.0
will grype support it?
https://nvd.nist.gov/general/news/cvss-v4-0-official-support

thanks!

Why is this needed:
be updated to the newest cvss
Additional context:

@tomersein tomersein added the enhancement New feature or request label Jul 1, 2024
@kzantow
Copy link
Contributor

kzantow commented Sep 18, 2024

Hey @tomersein, are you asking to make sure that if CVSS 4 information is present in records, Grype DB includes this?

@kzantow
Copy link
Contributor

kzantow commented Sep 18, 2024

Developer note: Look at this library for parsing CVSS: https://github.com/pandatix/go-cvss

@TimBrown1611
Copy link

yes correct, just want to make sure grype \ vunnel gets and displays this information :)

@willmurphyscode
Copy link
Contributor

willmurphyscode commented Oct 9, 2024

@wagoodman @kzantow does it make sense to try to do this as part of schema v6?

EDIT: we discussed this offline, and this can be done before or after grype db v6, but will require figuring out which providers over in anchore/vunnel can provide cvss v4 data, and wiring it through vunnel and grype-db and adding it to the appropriate structs in grype so that it gets displayed.

@willmurphyscode willmurphyscode moved this to Backlog in OSS Oct 9, 2024
@willmurphyscode willmurphyscode moved this from Backlog to Ready in OSS Oct 9, 2024
@luhring
Copy link
Contributor

luhring commented Nov 6, 2024

I think I'm starting to see this showing up more — e.g. for https://nvd.nist.gov/vuln/detail/CVE-2024-9287, the CNA (the PSF in this case) has marked this as "medium". But in Grype's DB, this record shows its severity as "unknown". I'm guessing that's because there's no non-CVSSv4 data available from NVD? So the net effect is slightly confusing to users who are cross-checking the upstream vuln data source.

@luhring
Copy link
Contributor

luhring commented Dec 12, 2024

this can be done before or after grype db v6, but will require figuring out which providers over in anchore/vunnel can provide cvss v4 data

If this doesn't need to wait for v6, and if no one's working on this already, I'd be happy to take a stab at it! Could we start with just NVD for now?

@westonsteimel
Copy link
Contributor

westonsteimel commented Dec 12, 2024

@luhring , I think anchore/grype-db#418 is where you'd need to start. vunnel is already capturing the entirety of the NVD json so grype-db just needs to be updated to parse it and persist to the db and then grype would need to understand how to parse and present it

@luhring
Copy link
Contributor

luhring commented Dec 12, 2024

Okay perfect — yeah that looks like a subtask of this issue. I'll take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Ready
Development

No branches or pull requests

7 participants