Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Density units *may* be incorrect #132

Open
CodeWithOz opened this issue Jul 29, 2018 · 0 comments
Open

Density units *may* be incorrect #132

CodeWithOz opened this issue Jul 29, 2018 · 0 comments

Comments

@CodeWithOz
Copy link

CodeWithOz commented Jul 29, 2018

@andismith I suspect there's something about the way the conversion works that I don't understand. I have only just begun using GraphicsMagick/this grunt plugin. Thanks in advance 🙌 .

Expected Behaviour

For an image generated with density: 150, GraphicsMagick should report its resolution as 150x150 pixels (which I believe means dpi).

Actual Behaviour

GraphicsMagick reports its resolution as 150x150 pixels/centimeter, which converts to 381 dpi.
See screenshot below.

gm_resolution

Steps to Reproduce

grunt responsive_images
See Gruntfile.js config below

PC/Mac and Graphics Engine used

PC (Windows 10), GraphicsMagick

Grunt Configuration

    responsive_images: {
      dev: {
        options: {
          sizes: [
            {
              quality: 60,
              width: 350,
              density: 150,
              name: '1x'
            }
          ]
        },

        files: [{
          expand: true,
          src: ['*.{jpg,png}', '!bitmoji_uche.jpg', '!real_uche.jpg'],
          cwd: 'images_sm/',
          dest: 'images_resp/sm/'
        }]
      }
    },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant