[S] Add cutout and gradient background #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This PR should provide some additional functionality to the library. This includes:
topRight
button as an alternating appearing feature (implements Highlight/spotlight view on tooltip display #194)CALayer
via a closure that can allow the consumer to do whatever they want with the bubble background. The example has been modified to include a gradient background for thebottomLeft
button (implements Feature:Support gradient background color #201)The
README.md
has been edited to:Testing
Testing the functionality should be entirely possible via the demo project already included within the project as I just edited the
topRight
andbottomLeft
button actions to modify thePopTip
conditionally. However, (hopefully enough) instructions are available in the updatedREADME.md
Closing notes
If there are any issues, or questions around these changes, please let me know! If all is good with this @andreamazz, it'd be great to be able to have it merged and the version bumped as appropriate! 😄
As an aside, when using the SwiftUI
func show
, if theSwiftUI
view contents is too wide, it expands the bubble to be off the screen, thus losing/"clipping" content. For a more basic SwiftUI view that is a simpleVStack
containing two childText
elements with long text, the text will not wrap as desired either.